v3 - add field trans to linkTitle and add lang as async #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christinaroise
changed the title
christinaroise
commented
Sep 25, 2024
| @@ -191,7 +193,7 @@ export const link = defineField({ | |||
| prepare(selection) { | |||
| const { title, type } = selection; | |||
| return { | |||
| title: title, | |||
| title: title[0].value, | |||
There was a problem hiding this comment.
To not overcomplicate this I've set it to index [0]. That might be an English translation or a Norwegian, but not something we can spend time on now.
mathiazom
reviewed
Sep 25, 2024
| @@ -14,6 +14,8 @@ import { apiVersion, dataset, projectId } from "./env"; | |||
| import { schema } from "./schema"; | |||
| import { legalDocumentID } from "./schemas/documents/admin/legalDocuments"; | |||
|
|
|||
| const SUPPORTED_LANGUAGES_QUERY = `*[_type == "languageSettings" && !(_id in path("drafts.*"))].languages[]{id, title}`; | |||
There was a problem hiding this comment.
Drafts are already filtered out in production, so do we need to check that?
There was a problem hiding this comment.
Good point, it's just that when testing in staging we get duplicates. 🤪
So a list of English, Norwegian, English, Norwegian....
mathiazom
approved these changes
Sep 25, 2024
anemne
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Adding field translations to Sanity for cases where we want to have translations to only specific fields.
⚠️ this does NOT support rich text ⚠️
Visual Overview (Image/Video)
If applicable, please include screenshots or a short video showcasing the changes you have made.
Insert images or videos here.
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request:
Additional Notes
Other comments relevant to this pull request.